xrpl-dev-portal icon indicating copy to clipboard operation
xrpl-dev-portal copied to clipboard

Published 20 hours ago • verified publisher icon XRPLF

Create Encode Address in Python3 for Bounty DGE-93

Open kasiimh1 opened this issue 2 years ago • 2 comments

kasiimh1 avatar Sep 03 '22 16:09 kasiimh1

Ripple internal ID: DGE-93

Milestone 1

kasiimh1 avatar Sep 03 '22 16:09 kasiimh1

Code samples are best written linearly, nested functions are hard to keep up with for code samples.

wojake avatar Sep 09 '22 03:09 wojake

Here's the updated link to the bounty this PR is referring to: https://github.com/XRPLBounties/Proposals/blob/main/bounties/0032%20Python%20Code%20Samples.md

JST5000 avatar Sep 27 '22 21:09 JST5000

@kasiimh1 Hey, I'm closing this PR since equivalent work has already been merged, BUT we are accepting this work for the Milestone 1 bounty in addition to the work by @wojake on this PR.

@kasiimh1 please follow the instructions here to claim this as a bounty :)

(For context on this - the goal of the bounty program is to encourage more people to start developing on important work in the ecosystem, and since this is original work submitted at a similar time with similar quality to the merged code we want to recognize that)

As an aside: Would you want feedback on your PR even though it's being closed just for learning sake? (If so I'm happy to share comments - but if not that's ok too)

JST5000 avatar Sep 29 '22 22:09 JST5000