xrpl-dev-portal icon indicating copy to clipboard operation
xrpl-dev-portal copied to clipboard

Add new currency faucets in XRPL testnet and devnet

Open wojake opened this issue 3 years ago • 6 comments

Hey @mDuo13 and @intelliot, if this feature request #https://github.com/ripple/rippled/issues/3897 has been implemented in the testnet and devnet, I think the faucet page should be updated, each request would give:

  • 500 XRP
  • 100 US Dollar
  • 100 Euro
  • 0.01 Bitcoin
  • 0.1 Ethereum

It would also be great if you guys could add a "Copy" button situated in the red boxes that i drew, so no human error would disturb the testing phase for developers.

image

wojake avatar Oct 05 '21 15:10 wojake

The copy-paste thing can be done easily enough. With the way trust lines work, the faucet cannot just arbitrarily issue tokens to new accounts... (I suppose it could start sending TrustSet transactions on behalf of the newly-generated account, but that sounds like a bit out of the scope of what a faucet should do.)

mDuo13 avatar Oct 05 '21 21:10 mDuo13

Oops, I forgotten about the fact that users need to add trust lines to their account.

Sending TrustSet transactions on behalf of the user would work, I guess we have to do it, I don't think there is any other way.

wojake avatar Oct 06 '21 01:10 wojake

@mDuo13 I did some testing with the faucet in testnet/devnet, when a user requests a new faucet, the faucet's main wallet sends 1000 XRP to the newly generated wallet, this might be a problem as someone could congest the network by spamming the "Generate X credentials".

So lets lower the test funds to only 3 (XRP,USD,BTC),

If we implement this new currency faucet for developers, 2 TrustSet transactions will be sent on behalf the user and 3 transaction is sent to the newly generated wallet.

which comes to ~5 Transactions per request.

I suppose adding a time limit to the faucet would be great as a safety measure (e.g: 1 request/5 seconds).

each request would give:
- 500 XRP
- 100 US Dollar
- 0.01 Bitcoin

Time Limit: 1 request/5 seconds | Avoid spam
Copy-Paste button besides the credentials | Avoid human error

wojake avatar Oct 06 '21 10:10 wojake

The amount of funds sent/received don't change the amount of network congestion involved. If anything, lowering the amount per request would cause more congestion since people would need to call the faucet more in order to get enough test-XRP to do whatever things they had in mind.

Personally, I don't think the faucet should be an issuer. It doesn't set up for the right expectations or understanding of how issuing tokens in the XRPL works.

mDuo13 avatar Oct 26 '21 06:10 mDuo13

Isn't this what Checks are made for? The faucet could on demand send out checks to a specified address and the user there just needs to cash it.

MarkusTeufelberger avatar Oct 31 '21 23:10 MarkusTeufelberger

Isn't this what Checks are made for? The faucet could on demand send out checks to a specified address and the user there just needs to cash it.

Oh ye that could boost the efficiency of the faucet, thank you for bringing that up :D

wojake avatar Nov 01 '21 05:11 wojake