Lending protocol - ongoing work and bug fixes - XLS-66

[ximinez]

High Level Overview of Change

This PR continues the work started in #5270 and #6093. All new code changes that affect Lending should be done in this branch. That includes PRs.

Implement the Lending Protocol as described in XLS-66

Context of Change

• PR https://github.com/XRPLF/XRPL-Standards/pull/240.
• Rendered

Type of Change

• [X] New feature (non-breaking change which adds functionality)
• [X] Refactor (non-breaking change that only restructures code)
• [X] Tests (you added tests for code that already exists, or your new feature included in this PR)

API Impact

• [ ] Public API: New feature (new methods and/or new fields)
• [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• [ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• [ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov[bot]]

Codecov Report

:x: Patch coverage is 95.14563% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 79.1%. Comparing base (d7c71bf) to head (b9aa354).

Files with missing lines	Patch %	Lines
src/xrpld/app/misc/detail/LendingHelpers.cpp	97.2%	2 Missing :warning:
src/xrpld/app/tx/detail/LoanSet.cpp	86.7%	2 Missing :warning:
src/xrpld/app/tx/detail/LoanPay.cpp	80.0%	1 Missing :warning:

Additional details and impacted files

@@                   Coverage Diff                    @@
##           ximinez/lending-XLS-66-2   #6102   +/-   ##
========================================================
  Coverage                      79.1%   79.1%           
========================================================
  Files                           839     839           
  Lines                         71402   71391   -11     
  Branches                       8325    8317    -8     
========================================================
+ Hits                          56477   56486    +9     
+ Misses                        14925   14905   -20     

Files with missing lines	Coverage Δ
include/xrpl/ledger/View.h	100.0% <ø> (ø)
src/xrpld/app/misc/LendingHelpers.h	95.0% <ø> (ø)
...rc/xrpld/app/tx/detail/LoanBrokerCoverClawback.cpp	97.8% <100.0%> (+<0.1%)	:arrow_up:
...rc/xrpld/app/tx/detail/LoanBrokerCoverWithdraw.cpp	96.3% <100.0%> (+0.1%)	:arrow_up:
src/xrpld/app/tx/detail/LoanBrokerDelete.cpp	83.5% <ø> (+11.0%)	:arrow_up:
src/xrpld/app/tx/detail/LoanBrokerSet.cpp	99.1% <100.0%> (+0.1%)	:arrow_up:
src/xrpld/app/tx/detail/LoanManage.cpp	87.7% <ø> (+2.4%)	:arrow_up:
src/xrpld/app/tx/detail/LoanManage.h	100.0% <ø> (ø)
src/xrpld/app/tx/detail/Transactor.cpp	92.2% <100.0%> (+0.2%)	:arrow_up:
src/xrpld/app/tx/detail/LoanPay.cpp	95.1% <80.0%> (-0.4%)	:arrow_down:
... and 2 more

... and 2 files with indirect coverage changes

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.