Lending protocol Part 2 for re-review - XLS-66

[ximinez]

High Level Overview of Change

This PR is effectively a clone of #5270 to allow for reviewers to have a "pristine" view of the change set that was merged in commit 6c67f1f525aa902e7c3cc3ff43b501ec5915da59.

The content of commits 6c67f1f525aa902e7c3cc3ff43b501ec5915da59 (in develop) and c953073c3aee91b456845b5ed3bcf6bc4ef56118 (the current state of this branch as of this update) are identical. (Note that I have rewritten the end of the branch since this PR was opened to bring it back into sync. Also note that the branch name kinda sucks.)

The only changes that should be made to this branch are fixes and other changes that are identified as part of a review of this PR.

There is a second PR, #6102, that is intended for any new code changes, bug fixes, and PRs that aren't identified as part of this PR.

Context of Change

• PR https://github.com/XRPLF/XRPL-Standards/pull/240.
• Rendered
• https://github.com/XRPLF/rippled/commits/release-3.0/

Type of Change

• [X] New feature (non-breaking change which adds functionality)
• [X] Refactor (non-breaking change that only restructures code)
• [X] Tests (you added tests for code that already exists, or your new feature included in this PR)

API Impact

• [ ] Public API: New feature (new methods and/or new fields)
• [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• [ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• [ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov[bot]]

Codecov Report

:x: Patch coverage is 91.10776% with 236 lines in your changes missing coverage. Please review. :warning: Please upload report for BASE (ximinez/develop-nolending@db11d27). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/xrpld/app/misc/detail/LendingHelpers.cpp	88.0%	67 Missing :warning:
src/xrpld/app/tx/detail/InvariantCheck.cpp	89.0%	27 Missing :warning:
src/xrpld/app/tx/detail/LoanManage.cpp	85.3%	27 Missing :warning:
src/xrpld/app/tx/detail/LoanSet.cpp	91.4%	27 Missing :warning:
src/xrpld/app/tx/detail/LoanBrokerDelete.cpp	72.5%	25 Missing :warning:
src/xrpld/rpc/handlers/LedgerEntry.cpp	0.0%	20 Missing :warning:
src/libxrpl/ledger/View.cpp	94.5%	16 Missing :warning:
src/xrpld/app/tx/detail/LoanPay.cpp	95.5%	11 Missing :warning:
...rc/xrpld/app/tx/detail/LoanBrokerCoverClawback.cpp	97.8%	3 Missing :warning:
src/xrpld/app/tx/detail/LoanBrokerCoverDeposit.cpp	94.8%	3 Missing :warning:
... and 6 more

Additional details and impacted files

@@                     Coverage Diff                     @@
##             ximinez/develop-nolending   #6093   +/-   ##
===========================================================
  Coverage                             ?   79.1%           
===========================================================
  Files                                ?     839           
  Lines                                ?   71402           
  Branches                             ?    8325           
===========================================================
  Hits                                 ?   56477           
  Misses                               ?   14925           
  Partials                             ?       0           

Files with missing lines	Coverage Δ
include/xrpl/basics/Number.h	100.0% <ø> (ø)
include/xrpl/json/json_value.h	98.5% <ø> (ø)
include/xrpl/ledger/ApplyView.h	100.0% <ø> (ø)
include/xrpl/ledger/View.h	100.0% <100.0%> (ø)
include/xrpl/protocol/Asset.h	96.3% <100.0%> (ø)
include/xrpl/protocol/Indexes.h	100.0% <100.0%> (ø)
include/xrpl/protocol/Protocol.h	100.0% <100.0%> (ø)
include/xrpl/protocol/SField.h	100.0% <ø> (ø)
include/xrpl/protocol/STAmount.h	95.7% <100.0%> (ø)
include/xrpl/protocol/STObject.h	93.1% <ø> (ø)
... and 49 more

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.