rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Refactor: Update PermissionedDomainDelete to use keylet for sle access

Open tequdev opened this issue 2 months ago • 1 comments

High Level Overview of Change

Refactor to explicitly use keylet::permissionedDomain in PermissionedDomainDelete processing.

Context of Change

  1. Refactor to explicitly use keylet::permissionedDomain in PermissionedDomainDelete processing.
  2. Fix to retrieve the Owner from the pDomain's Owner field instead of the Account field of the transaction. (This is a non-breaking change as these are checked to be the same value in preclaim().)

Type of Change

  • [x] Refactor (non-breaking change that only restructures code)

tequdev avatar Nov 21 '25 09:11 tequdev

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 78.6%. Comparing base (adbeb94) to head (5b25a5b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6063   +/-   ##
=======================================
  Coverage     78.6%   78.6%           
=======================================
  Files          818     818           
  Lines        68989   68990    +1     
  Branches      8249    8236   -13     
=======================================
+ Hits         54203   54217   +14     
+ Misses       14786   14773   -13     
Files with missing lines Coverage Δ
...c/xrpld/app/tx/detail/PermissionedDomainDelete.cpp 100.0% <100.0%> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 21 '25 10:11 codecov[bot]