rippled
rippled copied to clipboard
Refactor: Update PermissionedDomainDelete to use keylet for sle access
High Level Overview of Change
Refactor to explicitly use keylet::permissionedDomain in PermissionedDomainDelete processing.
Context of Change
- Refactor to explicitly use
keylet::permissionedDomaininPermissionedDomainDeleteprocessing. - Fix to retrieve the
Ownerfrom the pDomain'sOwnerfield instead of theAccountfield of the transaction. (This is a non-breaking change as these are checked to be the same value inpreclaim().)
Type of Change
- [x] Refactor (non-breaking change that only restructures code)
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 78.6%. Comparing base (adbeb94) to head (5b25a5b).
Additional details and impacted files
@@ Coverage Diff @@
## develop #6063 +/- ##
=======================================
Coverage 78.6% 78.6%
=======================================
Files 818 818
Lines 68989 68990 +1
Branches 8249 8236 -13
=======================================
+ Hits 54203 54217 +14
+ Misses 14786 14773 -13
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...c/xrpld/app/tx/detail/PermissionedDomainDelete.cpp | 100.0% <100.0%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.