rippled icon indicating copy to clipboard operation
rippled copied to clipboard

refactor: Rename `ripple` namespace to `xrpl`

Open bthomee opened this issue 2 months ago • 3 comments

High Level Overview of Change

This change renames all occurrences of namespace ripple and ripple:: to namespace xrpl and xrpl::, respectively. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts.

Context of Change

Per XLS-0095, we are taking steps to rename ripple(d) to xrpl(d).

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [X] Refactor (non-breaking change that only restructures code)
  • [ ] Performance (increase or change in throughput and/or latency)
  • [ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation update
  • [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • [ ] Release

bthomee avatar Nov 01 '25 18:11 bthomee

Codecov Report

:x: Patch coverage is 73.46939% with 13 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 79.1%. Comparing base (496efb7) to head (801824e). :warning: Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
include/xrpl/protocol/json_get_or_throw.h 0.0% 4 Missing :warning:
include/xrpl/protocol/AccountID.h 0.0% 1 Missing :warning:
include/xrpl/protocol/PublicKey.h 0.0% 1 Missing :warning:
include/xrpl/protocol/STAmount.h 0.0% 1 Missing :warning:
include/xrpl/protocol/Units.h 0.0% 1 Missing :warning:
include/xrpl/server/detail/BasePeer.h 0.0% 1 Missing :warning:
src/libxrpl/json/Object.cpp 50.0% 1 Missing :warning:
src/libxrpl/json/Writer.cpp 50.0% 1 Missing :warning:
src/libxrpl/json/json_reader.cpp 0.0% 1 Missing :warning:
src/libxrpl/ledger/Dir.cpp 0.0% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5982     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          839     839             
  Lines        71391   71386      -5     
  Branches      8335    8336      +1     
=========================================
- Hits         56452   56448      -4     
+ Misses       14939   14938      -1     
Files with missing lines Coverage Δ
include/xrpl/basics/BasicConfig.h 88.6% <ø> (ø)
include/xrpl/basics/Buffer.h 100.0% <ø> (ø)
include/xrpl/basics/ByteUtilities.h 100.0% <ø> (ø)
include/xrpl/basics/CompressionAlgorithms.h 0.0% <ø> (ø)
include/xrpl/basics/CountedObject.h 100.0% <ø> (ø)
include/xrpl/basics/DecayingSample.h 88.6% <ø> (ø)
include/xrpl/basics/Expected.h 100.0% <ø> (ø)
include/xrpl/basics/IntrusivePointer.h 91.7% <ø> (ø)
include/xrpl/basics/IntrusivePointer.ipp 86.7% <ø> (ø)
include/xrpl/basics/IntrusiveRefCounts.h 92.8% <ø> (ø)
... and 237 more

... and 35 files with indirect coverage changes

Impacted file tree graph

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 01 '25 19:11 codecov[bot]

Can/Should we also replace BEAST_DEFINE_TESTSUITE(DeliverMin, app, ripple);?

dangell7 avatar Dec 10 '25 11:12 dangell7

Also PR for validator tools: https://github.com/ripple/validator-keys-tool/pull/59

dangell7 avatar Dec 10 '25 11:12 dangell7

Can/Should we also replace BEAST_DEFINE_TESTSUITE(DeliverMin, app, ripple);?

Yes, good idea. I included that in the script and added the modified files to this PR.

bthomee avatar Dec 10 '25 23:12 bthomee