rippled
rippled copied to clipboard
TEMP DRAFT: Ximinez/vault test
High Level Overview of Change
Context of Change
Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Performance (increase or change in throughput and/or latency)
- [ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
- [ ] Documentation update
- [ ] Chore (no impact to binary, e.g.
.gitignore, formatting, dropping support for older tooling) - [ ] Release
API Impact
- [ ] Public API: New feature (new methods and/or new fields)
- [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
- [ ]
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl) - [ ] Peer protocol change (must be backward compatible or bump the peer protocol version)
Codecov Report
:x: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 78.7%. Comparing base (ffeabc9) to head (233ad4a).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/xrpld/app/main/Main.cpp | 55.6% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #5394 +/- ##
=======================================
Coverage 78.7% 78.7%
=======================================
Files 816 816
Lines 72275 72285 +10
Branches 8542 8522 -20
=======================================
+ Hits 56872 56882 +10
Misses 15403 15403
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/xrpld/app/main/Main.cpp | 78.0% <55.6%> (-1.0%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.