DRAFT: Optimize when to acquire ledgers from the network

[ximinez]

High Level Overview of Change

Context of Change

Type of Change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Refactor (non-breaking change that only restructures code)
• [ ] Performance (increase or change in throughput and/or latency)
• [ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
• [ ] Documentation update
• [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• [ ] Release

API Impact

• [ ] Public API: New feature (new methods and/or new fields)
• [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• [ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• [ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 69.15888% with 33 lines in your changes missing coverage. Please review.

Please upload report for BASE (ximinez/fix-getledger@3a685d6). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/xrpld/app/ledger/detail/InboundLedger.cpp	71.0%	9 Missing :warning:
src/xrpld/app/ledger/detail/LedgerMaster.cpp	0.0%	9 Missing :warning:
src/xrpld/app/misc/NetworkOPs.cpp	50.0%	7 Missing :warning:
src/xrpld/app/ledger/detail/InboundLedgers.cpp	86.4%	3 Missing :warning:
src/xrpld/app/ledger/detail/LedgerCleaner.cpp	0.0%	2 Missing :warning:
src/xrpld/rpc/detail/RPCHelpers.cpp	33.3%	2 Missing :warning:
src/xrpld/app/ledger/detail/TimeoutCounter.cpp	95.0%	1 Missing :warning:

Additional details and impacted files

@@                   Coverage Diff                   @@
##             ximinez/fix-getledger   #5352   +/-   ##
=======================================================
  Coverage                         ?   77.9%           
=======================================================
  Files                            ?     796           
  Lines                            ?   68974           
  Branches                         ?    8419           
=======================================================
  Hits                             ?   53755           
  Misses                           ?   15219           
  Partials                         ?       0           

Files with missing lines	Coverage Δ
src/xrpld/app/consensus/RCLValidations.cpp	74.3% <100.0%> (ø)
src/xrpld/app/ledger/InboundLedger.h	69.2% <ø> (ø)
src/xrpld/app/ledger/InboundLedgers.h	100.0% <ø> (ø)
src/xrpld/app/ledger/detail/LedgerDeltaAcquire.cpp	96.4% <100.0%> (ø)
src/xrpld/app/ledger/detail/LedgerReplayTask.cpp	94.1% <100.0%> (ø)
src/xrpld/app/ledger/detail/SkipListAcquire.cpp	96.6% <100.0%> (ø)
src/xrpld/app/ledger/detail/TimeoutCounter.h	100.0% <ø> (ø)
src/xrpld/app/misc/NetworkOPs.h	100.0% <ø> (ø)
src/xrpld/shamap/detail/NodeFamily.cpp	35.9% <ø> (ø)
src/xrpld/app/ledger/detail/TimeoutCounter.cpp	89.3% <95.0%> (ø)
... and 6 more

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.