rippled icon indicating copy to clipboard operation
rippled copied to clipboard
verified publisher icon XRPLF

Add Obsolete indicator to non-admin `feature` RPC

Open pdp2121 opened this issue 1 year ago • 4 comments

Summary

Obsolete indicator is only available in feature RPC response via vetoed, which is unavailable in non-admin mode. Another boolean field (e.g obsolete/retired) should be added to feature response to identify amendments that are marked as obsolete in the code.

Motivation

Non-admin feature RPC should show obsolete information.

pdp2121 avatar Dec 12 '24 22:12 pdp2121

See also #4730

ximinez avatar Dec 16 '24 19:12 ximinez

Related, it's misleading that the feature command shows retired amendments as "enabled": false even though the functionality associated with them is always enabled. Previous ticket: #4014.

mDuo13 avatar Feb 04 '25 00:02 mDuo13

I think this issue would be solved with #4730

mvadari avatar Feb 05 '25 19:02 mvadari

Related, it's misleading that the feature command shows retired amendments as "enabled": false even though the functionality associated with them is always enabled. Previous ticket: #4014.

Without adding a new state, rippled can't tell the difference between a retired feature and an obsolete feature. All enabled really tells you is whether the ID of the amendment is in the ledger. A better solution might be to hide / expunge any obsolete amendments that are not "enabled".

ximinez avatar Feb 27 '25 01:02 ximinez