Mac UT check

[oleks-rip]

High Level Overview of Change

MACOS unit tests fix

Context of Change

Add retries to Env RPC requests to fix Macos disconnects during CI testing. RPC server use ip ports assigned by operating system automatically (instead of hard-coded) when unit tests run.

Type of Change

• [x] Bug fix (non-breaking change which fixes an issue)

API Impact

• [x] No API impact

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 92.20779% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.0%. Comparing base (b6e3453) to head (e51876d). Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/xrpld/core/detail/Config.cpp	88.2%	2 Missing :warning:
src/xrpld/rpc/detail/ServerHandler.cpp	85.7%	2 Missing :warning:
src/xrpld/app/main/Application.cpp	93.8%	1 Missing :warning:
src/xrpld/app/main/GRPCServer.cpp	93.3%	1 Missing :warning:

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #5196   +/-   ##
=======================================
  Coverage     78.0%   78.0%           
=======================================
  Files          789     789           
  Lines        67007   67060   +53     
  Branches      8107    8109    +2     
=======================================
+ Hits         52278   52321   +43     
- Misses       14729   14739   +10     

Files with missing lines	Coverage Δ
include/xrpl/basics/BasicConfig.h	87.2% <ø> (ø)
include/xrpl/server/detail/ServerImpl.h	92.5% <100.0%> (+0.8%)	:arrow_up:
src/libxrpl/basics/BasicConfig.cpp	89.6% <100.0%> (ø)
src/libxrpl/server/Port.cpp	76.8% <100.0%> (+0.2%)	:arrow_up:
src/xrpld/app/main/GRPCServer.h	100.0% <ø> (ø)
src/xrpld/overlay/detail/OverlayImpl.cpp	34.7% <100.0%> (ø)
src/xrpld/rpc/ServerHandler.h	100.0% <100.0%> (ø)
src/xrpld/app/main/Application.cpp	69.3% <93.8%> (+0.4%)	:arrow_up:
src/xrpld/app/main/GRPCServer.cpp	44.4% <93.3%> (+2.0%)	:arrow_up:
src/xrpld/core/detail/Config.cpp	75.2% <88.2%> (+0.5%)	:arrow_up:
... and 1 more

... and 2 files with indirect coverage changes

[oleks-rip]

I started this review, but I didn't post it, and I'm not sure if I finished. Consider it a partial review.

It is not considered finished until approved, feel free to make breaks among your reviews.

[oleks-rip]

2. Please don't resolve comments that I (and others?) leave in reviews, unless Github does it automatically (i.e. through the "Accept Suggestion" button). Again, it makes it a lot easier for me to follow up on my previous feedback when it may have been long enough that I don't remember precisely what I said, or where I said it.

After some numbers of open conversations GH going crazy and makes review impossible. It will randomly drop you to some another comment when you just reading something. When you scroll - it will shows you some random previous comments. When you reply it can redirect you replying to another comment. It became slow and unresponsive. (I observe this on different machines, OS and browsers, it is not my cache)

[ximinez]

After some numbers of open conversations GH going crazy and makes review impossible. It will randomly drop you to some another comment when you just reading something. When you scroll - it will shows you some random previous comments. When you reply it can redirect you replying to another comment. It became slow and unresponsive. (I observe this on different machines, OS and browsers, it is not my cache)

Weeeeeird.