rippled
rippled copied to clipboard
Fixing levelization.sh script to ignore commented out includes
High Level Overview of Change
Issue raised in: https://github.com/XRPLF/rippled/issues/5193
Context of Change
Added simple check to ignore single-line comments during dependency analysis.
Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Performance (increase or change in throughput and/or latency)
- [ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
- [ ] Documentation update
- [x] Chore (no impact to binary, e.g.
.gitignore, formatting, dropping support for older tooling) - [ ] Release
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.0%. Comparing base (
9e4a7d5) to head (b6723b3). Report is 1 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #5194 +/- ##
=======================================
Coverage 78.0% 78.0%
=======================================
Files 789 789
Lines 66955 66955
Branches 8110 8108 -2
=======================================
+ Hits 52215 52219 +4
+ Misses 14740 14736 -4
@vlntb Is this ready to merge? If so, please provide a good commit message to use on the merge.