rippled icon indicating copy to clipboard operation
rippled copied to clipboard

test: enable TxQ unit tests work with variable reference fee (#5118)

Open vvysokikh1 opened this issue 1 year ago • 1 comments

High Level Overview of Change

Fix TxQ unit tests to be able to process reference fee value other than 10.

Context of Change

In preparation for potential reference fee change we would like to verify that fee change works as expected. The first step is to fix all unit tests to be able to work with different reference fee values.

Type of Change

  • [x ] Tests (you added tests for code that already exists, or your new feature included in this PR)

API Impact

None

Test Plan

Tested following reference fee values: 10, 20, 50, 100, 200, 500, 1000 by changing https://github.com/vvysokikh1/rippled/blob/2f432e812cb773048530ebfaf2e0e6def51e3cc2/src/test/jtx/impl/envconfig.cpp#L47

vvysokikh1 avatar Sep 06 '24 09:09 vvysokikh1

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.1%. Comparing base (53ea31c) to head (83ce629).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5118   +/-   ##
=======================================
  Coverage     78.1%   78.1%           
=======================================
  Files          790     790           
  Lines        67908   67908           
  Branches      8229    8226    -3     
=======================================
+ Hits         53024   53033    +9     
+ Misses       14884   14875    -9     

see 4 files with indirect coverage changes

Impacted file tree graph

codecov[bot] avatar Sep 06 '24 14:09 codecov[bot]