rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Additional unit tests for testing deletion of trust lines

Open ckeshava opened this issue 1 year ago • 2 comments

High Level Overview of Change

This PR includes additional unit tests for testing deletion of trust lines.

Context of Change

The tests verify if the trust lines are removed from the owner directory once the settings are restored to defaults.

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (non-breaking change that only restructures code)
  • [x] Tests (you added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation update
  • [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • [ ] Release

API Impact

  • [ ] Public API: New feature (new methods and/or new fields)
  • [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • [ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • [ ] Peer protocol change (must be backward compatible or bump the peer protocol version) No change to APIs

ckeshava avatar Jan 17 '24 21:01 ckeshava

@Bronek I have added three new unit tests to validate the negative results in 2e0dfce

ckeshava avatar Jan 27 '24 00:01 ckeshava

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.3%. Comparing base (58f3abe) to head (64005df).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #4886     +/-   ##
=========================================
- Coverage     71.3%   71.3%   -0.0%     
=========================================
  Files          796     796             
  Lines        66883   66883             
  Branches     10865   10868      +3     
=========================================
- Hits         47687   47683      -4     
- Misses       19196   19200      +4     

see 3 files with indirect coverage changes

Impacted file tree graph

codecov-commenter avatar Jan 27 '24 01:01 codecov-commenter