rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Amendment XLS-35: URIToken — Lightweight first-class NFTs

Open dangell7 opened this issue 2 years ago • 9 comments

High Level Overview of Change

The URIToken Amendment (XLS-35d) provides a lightweight alternative to XLS20 suitable for both main-net and side-chains.

The amendment adds:

A new type of ledger object: ltURI_TOKEN A new serialized field: URITokenID Five new transaction types:

URITokenMint URITokenBurn URITokenBuy URITokenCreateSellOffer URITokenCancelSellOffer

  • [x] New feature (non-breaking change which adds functionality)

dangell7 avatar Mar 09 '23 11:03 dangell7

@dangell7 is this ready for review?

intelliot avatar Apr 24 '23 18:04 intelliot

note: there are merge conflicts you'd need to resolve

intelliot avatar Apr 24 '23 18:04 intelliot

@dangell7 is this ready for review?

Ready for review

dangell7 avatar Apr 24 '23 22:04 dangell7

I am requesting a code review on this. Anyone feel like reviewing it please?

RichardAH avatar May 23 '23 17:05 RichardAH

I am requesting a code review on this. Anyone feel like reviewing it please?

From the ripple side, @ledhed2222 will be able to help provide code review on this. In terms of timing, I'm predicting he will be able to get to this in two weeks or so

It would be great if we can seek additional help from non-ripple in terms for code review so that we can get more community representation/participation in this process. Would anyone else be able to help review? 🙏

kennyzlei avatar May 24 '23 22:05 kennyzlei

just started taking a look at this :)

ledhed2222 avatar Jun 13 '23 17:06 ledhed2222

@ledhed2222 Thank you very much for your time and review of the code. I have marked everything that I have updated with a thumbs up.

Richard and I are going to address some of the other comments and then I will push the changes for a second review.

dangell7 avatar Jun 22 '23 13:06 dangell7

@dangell7 - at your convenience, please respond to the comments above

intelliot avatar Sep 08 '23 05:09 intelliot

lacks reviews - community is welcome to review.

intelliot avatar Oct 03 '23 17:10 intelliot