rippled icon indicating copy to clipboard operation
rippled copied to clipboard

remove deprecated fields in ledger command, fix for #3214

Open ckeshava opened this issue 3 years ago • 1 comments
trafficstars

I removed the following fields from the ledger command - accepted, seq, hash and totalCoins.

Some of these variable names (totalCoins, seq) are used in managing the database but I don't think there is any redundancy in the creation/updation/deletion of the tables.

ckeshava avatar Jul 20 '22 00:07 ckeshava

I don't know if we can just remove the deprecated field; someone might still be relying on it. Do we know how long it's been marked DEPRECATED for? @mDuo13, any objections?

nbougalis avatar Aug 03 '22 21:08 nbougalis

Per #3214, the fields have been marked as deprecated dating back to at least 2015. I think we can just remove them.

mDuo13 avatar Nov 28 '22 21:11 mDuo13

@mDuo13 any thoughts on jss::hash?

intelliot avatar Apr 06 '23 23:04 intelliot

The hash field in ledger_request should stay (for now). That command has its own problems, but I don't think it uses the shared ledger deserialization that this ticket is about.

mDuo13 avatar Apr 18 '23 16:04 mDuo13

This is slated for inclusion in 1.12 (not 1.11) unless anyone comments here to request otherwise.

intelliot avatar May 25 '23 17:05 intelliot

Released in 1.12.0.

intelliot avatar Sep 25 '23 15:09 intelliot