rippled
rippled copied to clipboard
remove deprecated fields in ledger command, fix for #3214
I removed the following fields from the ledger command - accepted, seq, hash and totalCoins.
Some of these variable names (totalCoins, seq) are used in managing the database but I don't think there is any redundancy in the creation/updation/deletion of the tables.
I don't know if we can just remove the deprecated field; someone might still be relying on it. Do we know how long it's been marked DEPRECATED for? @mDuo13, any objections?
Per #3214, the fields have been marked as deprecated dating back to at least 2015. I think we can just remove them.
@mDuo13 any thoughts on jss::hash?
The hash field in ledger_request should stay (for now). That command has its own problems, but I don't think it uses the shared ledger deserialization that this ticket is about.
This is slated for inclusion in 1.12 (not 1.11) unless anyone comments here to request otherwise.
Released in 1.12.0.