clio
clio copied to clipboard
refactor: Clio Config
Implementation of new config definition + methods + UT
Steps that still need to be implemented:
- Make ClioConfigDefinition and it's method to be as constexpr as possible
- Getting User Config file and populating the values in ConfigDefinition while checking for constraints on user values
- Replacing all the places where we fetch config values (by using config.valueOr/MaybeValue) to instead get it from Config Definition
- Generate markdown file using Clio Config Description
Codecov Report
Attention: Patch coverage is 87.62376% with 25 lines in your changes missing coverage. Please review.
Project coverage is 69.56%. Comparing base (
2a74a65) to head (fe84a9c).
Additional details and impacted files
@@ Coverage Diff @@
## develop #1544 +/- ##
===========================================
+ Coverage 69.19% 69.56% +0.37%
===========================================
Files 244 254 +10
Lines 9702 9904 +202
Branches 5384 5466 +82
===========================================
+ Hits 6713 6890 +177
- Misses 1589 1595 +6
- Partials 1400 1419 +19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for taking the time to review @godexsoft @cindyyan317 🙇
There should be also tests for Array, ConfigConstraints (or delete them for now), ConfigDefinition, ConfigValue.