XRPLF
XLS-56d: Atomic/Batch Transactions
Discussion thread can be found here: https://github.com/XRPLF/XRPL-Standards/discussions/162
This PR will be left open for easier commenting of specific lines/sections. The discussion will also still be available for ease of commenting for non-technical people.
An Inner account delete should be blocked if the same account is submitting the batch.
I'm currently signing the entire txn for BatchSigners as I do not understand the TxnIDs completely and have not implemented that. It will also require more custom logic in both the rippled and repos to sign an array of hashes and a flag field.
RE BatchIndex
Before it was thought that the batch index was the index of the transaction for a specific account. Now or with the addition of tickets, it is more correctly the index of the transaction for an account/sequence/ticket. Previously we were adding +1 to the sequence calculation if the batch txn was the outer account, however if using a combination of sequence and tickets there is no way to know. So the index needs to be calculated prior to submission.
Some examples.
OuterTxn: Alice using ticket
InnerTxn: Alice using sequence (Index = 0)
InnerTxn: Alice using sequence (Index = 1)
OuterTxn: Alice using ticket
InnerTxn: Alice using ticket (Index = 1)
InnerTxn: Alice using sequence (Index = 0)
OuterTxn: Alice using sequence
InnerTxn: Alice using ticket (Index = 0)
InnerTxn: Alice using sequence (Index = 1)
I think BatchExecutions in the metadata is missing in the spec
@shawnxie999 see this section: https://github.com/mvadari/XRPL-Standards/blob/batch/XLS-0056d-batch/README.md#261-outer-transactions
What's the influence of
Batchtransactions on the open-ledger cost? For instance, if 10Batchtransactions are included in a validated ledger, this is equivalent to inserting at most 80 non-Batch"usual" transactions. Is the soft-limit of the open-ledger cost calculation proportionately increased by this amendment?
The open-ledger cost is tied to the total fee of all the Batch transactions, on the outer transaction.