BasicSR icon indicating copy to clipboard operation
BasicSR copied to clipboard

[BREAKING FIX] [torchvision 0.17] Change functional_tensor import

Open TornjV opened this issue 1 year ago • 5 comments

Fix for #649

TornjV avatar Nov 16 '23 09:11 TornjV

torchvision 0.17 was just released: https://github.com/pytorch/vision/releases/tag/v0.17.0

psychedelicious avatar Feb 02 '24 00:02 psychedelicious

can we merge it? 2 months since 0.17 released.

keepdying avatar Apr 02 '24 10:04 keepdying

Over at Invoke, we only use the RealESRGAN functionality provided by basicsr.

I extracted the relevant classes and cleaned them up a bit:

Maybe this is useful for others who only use this library for upscaling and would like to keep their other dependencies up to date.

psychedelicious avatar Apr 02 '24 12:04 psychedelicious

Over at Invoke, we only use the RealESRGAN functionality provided by basicsr.

The Spandrel project by the chaiNNer folks (disclaimer: I'm a contributor, and I also wired Spandrel up into a1111 in https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/14425) implements RealESRGAN and various other upscaling and enhancement models in a clean way.

akx avatar Apr 02 '24 13:04 akx

Thanks for the link @akx ! This looks like a very ergonomic API, great work. Much nicer than what the basicsr repo provides (and my extracted version of it).

psychedelicious avatar Apr 02 '24 13:04 psychedelicious

could we release a new version with this fix?

yulin-li avatar Jul 19 '24 12:07 yulin-li