BasicSR icon indicating copy to clipboard operation
BasicSR copied to clipboard

Adding the LPIPS metrics

Open RebornForPower opened this issue 3 years ago • 6 comments

I have add the lpips metrice by referring the https://github.com/xinntao/BasicSR/pull/367

RebornForPower avatar Sep 24 '21 08:09 RebornForPower

editing the __init__.py and adding the lpips.py file which can be supported by the ymal file to test

RebornForPower avatar Sep 24 '21 08:09 RebornForPower

@RebornForPower Thanks for the contribution:-)

As LPIPS takes torch tensors as inputs, we may need to directly pass torch tensors into this metric.

Let me think about it and it may involve the modification to the metric mechanism.

xinntao avatar Sep 27 '21 02:09 xinntao

@RebornForPower Thanks for the contribution:-)

As LPIPS takes torch tensors as inputs, we may need to directly pass torch tensors into this metric.

Let me think about it and it may involve the modification to the metric mechanism.

why not process the img into tensor in the calculate function?

RebornForPower avatar Sep 28 '21 11:09 RebornForPower

This pull request introduces 1 alert when merging a74fb5751cd002481d78cec4d3a118fc47d42605 into 4d34d071218d0e767096eddefa919200d5239936 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

lgtm-com[bot] avatar Nov 09 '21 12:11 lgtm-com[bot]

This pull request introduces 1 alert when merging 10f55c8efd030a7c7a05f9502858b56f2d8c6cb5 into 4d34d071218d0e767096eddefa919200d5239936 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

lgtm-com[bot] avatar Nov 10 '21 06:11 lgtm-com[bot]

This pull request introduces 1 alert when merging 556909df827b71d96c525e8a38445c99e7929c4e into 4d34d071218d0e767096eddefa919200d5239936 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

lgtm-com[bot] avatar Nov 11 '21 08:11 lgtm-com[bot]