signxml icon indicating copy to clipboard operation
signxml copied to clipboard

Published 20 hours ago • verified publisher icon XML-Security

Add xades support

Open pokoli opened this issue 2 years ago • 1 comments

Hi,

Here is the implementation of #90 For now we just include basic properties of xades but it works for simple implementations.

I will like to have some feedback of the maintainers to now what is required to include this feature as part of a new release. Do we need full xades support or we can start which just basic functionalities?

P.S: There are a lot of old commits here, do you think it makes sense to merge them into a single one to make the review easier?

pokoli avatar Sep 14 '22 13:09 pokoli

Note that on last commit I use the default parameter of namedtuple which is only available on python 3.7. I've created #200 which removes support for Python 3.6, this is a requirement to allow merging this PR.

pokoli avatar Sep 15 '22 15:09 pokoli

Thanks everyone for your work on this PR. XAdES support was added in v3.0.0 using a different code structure. Please test v3.0.0 and let us know whether it suits your needs.

kislyuk avatar Nov 14 '22 00:11 kislyuk

@kislyuk great news! any code recommended to read ? I would like to improve documentation and add some examples about XaDES

ovnicraft avatar Nov 14 '22 01:11 ovnicraft

Found it http://xml-security.github.io/signxml/#xades-signatures !

ovnicraft avatar Nov 14 '22 01:11 ovnicraft