signxml icon indicating copy to clipboard operation
signxml copied to clipboard

get serialNumber from subject

Open busla opened this issue 6 years ago • 3 comments

Allows the serialNumber to be extracted and validated from cert Subject.

busla avatar Sep 06 '18 11:09 busla

Codecov Report

Merging #118 into master will decrease coverage by 0.1%. The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   94.89%   94.78%   -0.11%     
==========================================
  Files           3        3              
  Lines         588      595       +7     
==========================================
+ Hits          558      564       +6     
- Misses         30       31       +1
Impacted Files Coverage Δ
signxml/__init__.py 94.48% <90.9%> (-0.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e5bf2c...780fcf5. Read the comment docs.

codecov-io avatar Sep 06 '18 13:09 codecov-io

Thank you for your contribution. Sorry about the delay in handling this PR.

To proceed, this will require tests and the tightening of the comparisons in _get_serial_number(). The in operator is inappropriate in both comparisons, I think.

(Tests are failing for an unrelated reason - I'll fix that in master.)

kislyuk avatar Nov 02 '18 19:11 kislyuk

@busla any news about this ? travis is broken

ovnicraft avatar Mar 17 '20 02:03 ovnicraft