2021-NeurIPS-NCR icon indicating copy to clipboard operation
2021-NeurIPS-NCR copied to clipboard

Published 20 hours ago • verified publisher icon XLearning-SCU

question on the loss

Open haochenglouis opened this issue 2 years ago • 1 comments

https://github.com/XLearning-SCU/2021-NeurIPS-NCR/blob/c0ea996cba4e23cc1f6b069e638463d6c4cb495f/NCR/model.py#L484

Line 484 and Line 486 in model.py. Should it be "margin" instead of "self.margin" since you have applied soft margin.

haochenglouis avatar May 25 '22 21:05 haochenglouis

Yes, this is a mistake, I have fix it in 31dd08e.

Thanks for your comment.

hi-zhenyu avatar Jun 08 '22 09:06 hi-zhenyu