XG-Proyect-v3.x.x icon indicating copy to clipboard operation
XG-Proyect-v3.x.x copied to clipboard

Combat not working PHP 8 fix

Open OceanicNomad opened this issue 1 year ago • 1 comments

Instead of dynamically creating the fighters property as in previous versions of PHP, we need to explicitly declare it at the beginning of the class.

https://github.com/XGProyect/XG-Proyect-v3.x.x/blob/d1d9dc7ed498c4417f41b955871d4b67e0bb39d7/app/Libraries/BattleEngine/CombatObject/PhysicShot.php#L62

Add private $fighters; below https://github.com/XGProyect/XG-Proyect-v3.x.x/blob/d1d9dc7ed498c4417f41b955871d4b67e0bb39d7/app/Libraries/BattleEngine/CombatObject/PhysicShot.php#L42

OceanicNomad avatar Aug 16 '23 19:08 OceanicNomad

[FIX] https://github.com/XGProyect/XG-Proyect-v3.x.x/issues/595

jonamix-ar avatar Feb 13 '24 01:02 jonamix-ar