revanced-creator icon indicating copy to clipboard operation
revanced-creator copied to clipboard
verified publisher icon XDream8

Outputted APK conflicts with the preinstalled APK

Open hakunamatata97k opened this issue 2 years ago • 3 comments

Hello there, Thanks for providing an easy-to-use script for building revanced apps.

Issue 1:

I have a small question though, lately I have noticed that the releases are not triggered or rather old. This is sadly the case in both the nighty page and the codeberg :/

So I ran the script locally using the provided instructions, but I'm getting an app with different options and different icons in comparison to the app that I used to download from the nighty page. :(

The last app I downloaded from the nighty page have the following info:

  • App version 18.19.35
  • The following app icon: Screenshot_2023-12-03-15-17-01-50_b783bf344239542886fee7b48fa4b892

Issue 2:

Moreover, I'm sadly unable to install the outputted APK as it conflicts with an existing package. See here:
IMG_20231203_153146

How to reproduce:

  1. install java 21 zulu.
  2. run sh -c "$(curl https://raw.githubusercontent.com/XDream8/revanced-creator/main/patch.sh)"
  3. install the app on a non-rooted device with a from factory pre-installed YouTube app.
  4. you will get a conflict as shown in the image.

The outputted files:

image

hakunamatata97k avatar Dec 03 '23 14:12 hakunamatata97k

This is a keystore issue. revanced-creator uses revanced-cli which generates a random keystore and uses it.

You can create your own keystore and pass it by using additional_args environment variable or flag like this:

export additional_args="--keystore=<keystore>"

Also there seems to be a problem with nightly. Here is the link to latest ci

XDream8 avatar Dec 04 '23 03:12 XDream8

@XDream8 could you please tell me how one should create one's own keystore? Am I missing something here?

Plus, to my understanding the keystore solution effects the issue 2, right? what is causing the app icon to differ from the revanced icon that i really like to the official YouTube icon when triggering the script?how come the yt apk from the github cli has the offical revanced icon and the local triggered cli Would using a custom keystore file brand the app with the YouTube icon?

Sorry for my ignorance and thanks in advance.

hakunamatata97k avatar Dec 30 '23 18:12 hakunamatata97k

To create a keystore you can use this command: keytool -genkey -v -keystore revanced.keystore -alias alias_name -keyalg RSA -keysize 2048 -validity 10000

The icon is related to Custom Branding patch. It was enabled by default before but now it is not.

Sorry for the late response :(

XDream8 avatar Jan 20 '24 05:01 XDream8