Fernando Tagawa

Results 11 comments of Fernando Tagawa

Thanks for this patch @osiewicz, it improves the results a lot. Only problem I've found is with a default Nextjs project: https://github.com/zed-industries/zed/assets/66138117/a05ce146-4da7-4d58-8a80-4c91fdf2ca30

Its a lot better now, one last thing. * Exact matches are not the first match https://github.com/zed-industries/zed/assets/66138117/fe4f4aff-5f11-4e9c-8cd4-ba48e984b018 This one i am not sure if is a problem: * Typing `word`...

I could reproduce the issue in a different way. 1. Have a input method that supports diacritics. 2. Type in an empty line something like `´`, `˙`, which is not...

Hmm, I opened this because even if focus on the window, the window first expects a click before expanding a directory. I think I will keep this open

> EDIT: It seems like the value of `first_mouse` is wrong on Wayland. The documentation states this: > > https://github.com/zed-industries/zed/blob/89039f6f34910fadce76c73258b731f0a016ccd6/crates/gpui/src/interactive.rs#L104-L105 > > But the Wayland client code checks only if...

> We talked about this on discord before, and @mikayla-maki mentioned this is intentional: ![image](https://private-user-images.githubusercontent.com/1282767/327962123-6d750c59-c6eb-4ea8-9ec0-83d3f9bb6455.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ4NDExNDQsIm5iZiI6MTcxNDg0MDg0NCwicGF0aCI6Ii8xMjgyNzY3LzMyNzk2MjEyMy02ZDc1MGM1OS1jNmViLTRlYTgtOWVjMC04M2QzZjliYjY0NTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MDRUMTY0MDQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTgwZWI4ZjE5YjY0ZjgyOTVmMzJjMGQzM2E3OWFhZjI5ODU3MTAyYmZlYjUxMWQ2N2NlNDU1YTcyZmYxNzdjOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.CTw6_ulVl-G61pPMMAErfSKqIzz8-xfpnsjQfrbdyYA) > > I personally never noticed that this is also the behavior on vscode. I...

> 1. Thanks for fixing the bug! We should definitely merge that. > > 2. I found the project panel opening a file when focusing the window to be confusing,...

> * (no suggestions window, but that one is a problem on the fcitx5 side that affects all other applications too) This one I think you need to configure, since...

> Weird, they don't seem to work for me. I thought they were unrelated to IME. Whats your Compositor and Input Method?

> ``` > - if let Some(range) = input_handler.marked_text_range() { > + if let Some(range) = input_handler.selected_text_range() { > ``` > > Does this affects any client behaviors? If so,...