LookingGlass icon indicating copy to clipboard operation
LookingGlass copied to clipboard

Fixed block particle duplication bug

Open Geforce132 opened this issue 8 years ago • 3 comments

This fixes the block-breaking duplication bug that occurs when there is a view in the same dimension as the player.

Geforce132 avatar Aug 08 '16 05:08 Geforce132

Looks good! :D Are there any side effect to removing and readding the renderer every frame? I think there is logic to detect the "main world" changing. Wouldn't it be more practical to only do this on that change?

XCompWiz avatar Aug 08 '16 12:08 XCompWiz

Ah, yeah, that would be better, lol.

What was the logic you were thinking of? I can hopefully test it out.

Geforce132 avatar Aug 08 '16 16:08 Geforce132

It's been a year, nearly, so I don't remember the exact location or if it is still in, but I recall a section of code detecting Overworld world changes (by comparison) and handling world changes somewhere. I feel the detection was probably in the ProxyWorldManager, though I think the handling was called from there and somewhere else. You shouldn't have to look far from this class, really.

XCompWiz avatar Aug 09 '16 07:08 XCompWiz