LookingGlass icon indicating copy to clipboard operation
LookingGlass copied to clipboard

Shaders cause graphical issues

Open Draco18s opened this issue 9 years ago • 13 comments

http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/1280070-mystcraft-0-11-0?comment=12777

Quote from Nnystyxx Not sure if this is the place to report LookingGlass issues, but using the GLSL shaders mod with LookingGlass and Mystcraft causes the latter's link panels to cover the entire screen when a book is opened. Not totally destructive, but distracting.

Draco18s avatar May 18 '15 12:05 Draco18s

I'd like a screenshot, if possible. Also, there are a lot of things at play here and I have no idea at all how the shaders mod does things. A screenshot might help me make an educated guess. Also fixed your quote. Sorry for editing.

XCompWiz avatar May 18 '15 19:05 XCompWiz

Forwarded your request back to the thread, hopefully he'll supply one here.

Draco18s avatar May 18 '15 19:05 Draco18s

2015-05-18_16 21 23

This was an F2 screenshot of my whole screen. Turning to default shaders caused all panels to be black but still take the whole screen. This did not make the clickable area any bigger. Switching to a page without the link panel worked fine.

On Liteloader 1.7.10 with Forge 10.13.3.1403.

Mods:

  • lookingglass-1.7.10-0.0.1.01
  • mystcraft-1.7.10-0.11.9.03
  • ShadersModCore-v2.3.28-mc1.7.10-f (1) (I will provide mods from the 1.7.10 folder if wanted.)

Shader Used: KUDA Shaders v5.0.3. Ultra.

nnystyxx avatar May 18 '15 20:05 nnystyxx

Tagging @karyonix. Any thoughts? I'll try throwing this into my dev environment and testing different variations of the rendering to see what is causing it.

@nnystyxx Have you tested the /lg-viewdim command to see if it does the same?

XCompWiz avatar May 18 '15 22:05 XCompWiz

/lg-viewdim 0 caused, uh. . a very strange flickering bug and the inability to do anything else. I assume the rendering was just inescapable-- the game ran fine still. Testing that without shaders shortly. .

Yeah, having shaders causes a viewdim 'mirror' in the air to make the game FREAK OUT. I have no good way of making a video of it. Maybe gfycat.

nnystyxx avatar May 18 '15 23:05 nnystyxx

I'd like to add that my logs were getting hammered by this same issue, here's a snippet: https://gist.github.com/AtomicBlom/7d2ce39e10086859be5d

AtomicBlom avatar May 22 '15 14:05 AtomicBlom

I'm having the exact same issue. Here's an example: https://dl.dropboxusercontent.com/u/55403585/2015-07-06_00.48.20.jpg

Snowy-Fox avatar Jul 05 '15 23:07 Snowy-Fox

Query: Does this happen only while the book is open, or forever after opening the book? Similarly, does it only happen while you can "see" the portal, or for as long as the portal is alive, regardless of if the portal is in your For?

XCompWiz avatar Jul 13 '15 01:07 XCompWiz

It's only when I'm looking in the Book. It disappears upon leaving the book GUI. I haven't seen it on any portals, as I've not seen any portals yet.

On Mon, Jul 13, 2015 at 2:51 AM, XCompWiz [email protected] wrote:

Query: Does this happen only while the book is open, or forever after opening the book? Similarly, does it only happen while you can "see" the portal, or for as long as the portal is alive, regardless of if the portal is in your For?

— Reply to this email directly or view it on GitHub https://github.com/XCompWiz/LookingGlass/issues/2#issuecomment-120782907 .

Snowy-Fox avatar Jul 14 '15 11:07 Snowy-Fox

"/lg-viewdim 0 caused, uh. . a very strange flickering bug and the inability to do anything else. I assume the rendering was just inescapable-- the game ran fine still. Testing that without shaders shortly. ." Occurs to me as well. I have both shaders and optifine installed. Is optifine compatible?

t2pellet avatar Jul 07 '16 16:07 t2pellet

Is optifine compatible?

Almost never. :P

@Snowy-Fox I missed the reference you made before. Very funny. :D

I honestly don't know what to do with this one. It's hard enough to warp the Minecraft renderer to support rendering others worlds to texture. Getting that to work with shaders and other mods playing with the render pipeline sounds pretty hairy. Minecraft's render pipeline, as of 1.7.10, isn't exactly well thought out. I've heard it improved markedly in 1.8. Maybe this will smooth out in a few updates. :P

If anyone can provide more info or aid it is most welcome.

XCompWiz avatar Jul 30 '16 23:07 XCompWiz

Probably LookingGlass is trying to render the other world view while rendering the item (book). This is definitely not possible with shaders as they use a lot of static state.

Alternative views can only be rendered outside of EntityRenderer.renderWorld() or even better outside of EntityRenderer.updateCameraAndRender().

The ScreenShotHelper uses this code to create a scaled world view:

            int mul = Config.getScreenshotSize();
            boolean resize = (OpenGlHelper.isFramebufferEnabled() && mul > 1);
            if(resize)
            {
              // Gui scale
              Config.getGameSettings().guiScale = guiScale * mul;
              // Resize framebuffer
              resize(width * mul, height * mul);
              // Pre-render, from Minecraft.runGameLoop() 
              GlStateManager.pushMatrix();
              GlStateManager.clear(16640);
              mc.getFramebuffer().bindFramebuffer(true);
              // Render world 
              mc.entityRenderer.updateCameraAndRender(mc.getRenderPartialTicks(), System.nanoTime());
            }

This is called from outside of EntityRenderer.updateCameraAndRender() and it is compatible with shaders.

sp614x avatar Oct 25 '17 15:10 sp614x

Some shader packs have different set of shaders for the different dimensions so trying to render a view of another dimension may cause the shaders to be reloaded, which is slow.

sp614x avatar Oct 25 '17 15:10 sp614x