XCSoar icon indicating copy to clipboard operation
XCSoar copied to clipboard

Duplicate Waypoints on short waypoint files

Open reuti1697 opened this issue 3 years ago • 9 comments

The waypoints apperar twice. It is a normal *.cup - File. Exportet from Strepla für LX9000

XCSoar versions having and not having the problem

Having: XCSoar v7.19 (debian) XCSoar7 v.20-Android It's the same behavior an Windows 7.21-PC

Having not: XCSoar 7.18 (debian)

Expected behavior

A waypoint corresponds to a waypoint in the CUP-File

Actual behavior

2 identic waypoints corresponds to 1 waypoint in the CUP-File

Steps to reproduce the behavior

  • Load the attached file as the sole file
  • Open the waypoint list via for example the guesture

Do you have any idea what may have caused this?

No Idea

Do you have an idea how to solve the issue?

No. Sorry

reuti1697 avatar Dec 27 '21 16:12 reuti1697

You did not specify the latest version which does not have the problem.

MaxKellermann avatar Dec 28 '21 18:12 MaxKellermann

I'm sorry, I can't quite tell. I always use the latest version of Google Play. I only noticed the error last week when I was creating new waypoint files. At first I thought there was something wrong with the waypoint files. But they seem correct to me. Thanks for your help and especially thanks for the great program. I love it. Can I do something for you? Peter.

reuti1697 avatar Dec 30 '21 09:12 reuti1697

Test.pdf

reuti1697 avatar Dec 30 '21 09:12 reuti1697

So i tested several versions and it seems to be connected to the search short name search feature, introduced in v7.19 https://github.com/XCSoar/XCSoar/commit/9474c3fa972f7a86c3f2c45732e99d62cc9ae378

  • This happens with cup files that have field 2 (shortname) defined.
  • The particular file here has only few waypoints, so all the waypoints appear without searching.
  • You can also trigger it when you use another filter criteria like direction, waypoints with shortname defined appear twice.
  • We knew it happens when

Some potential approaches:

  • Seperate the name / shortname searches and use different fields in the "Select Waypoiint" Dialog
  • Find a way to eliminate duplicates in the radix tree.

lordfolken avatar Dec 30 '21 19:12 lordfolken

See https://github.com/XCSoar/XCSoar/pull/743

MaxKellermann avatar Dec 30 '21 19:12 MaxKellermann

I'm also facing same issue when selecting type Landable for example

Screenshot_2022-05-07-08-17-19-57_943b36a15770a48ab82837a5cf06e5e4

But not when filtering by distance

Screenshot_2022-05-07-08-16-59-30_943b36a15770a48ab82837a5cf06e5e4

s-celles avatar May 07 '22 06:05 s-celles

I don't know if that's related but removing waypoints file(s) in config and waypoints are still present on the map as if XCSoar was silently loading waypoints whereas I explicitely ask for no waypoints (or there is a kind of cache). Maybe it could explain why they are displayed twice.

Screenshot_2022-05-07-08-36-03-75_943b36a15770a48ab82837a5cf06e5e4

Screenshot_2022-05-07-08-36-10-14_943b36a15770a48ab82837a5cf06e5e4

s-celles avatar May 07 '22 06:05 s-celles

I gave up the Waypoint Code

yo7ckp avatar Jul 05 '22 19:07 yo7ckp