octocrab icon indicating copy to clipboard operation
octocrab copied to clipboard

No logging or errors when authentication fails

Open Chronophylos opened this issue 3 years ago • 2 comments

I'm trying to dispatch a actions workflow but it does not work. There is no log indicating the authentication might have failed nor does the .send() function return the response, nor does the .send() function check if github returned 403 or similar.

I used the _post() function to manually send the request but it returns 401 Bad Credentials. I'm using a personal token. I noticed that the api docs suggest using basic http authentication and the username:password format https://docs.github.com/en/rest/overview/other-authentication-methods#via-oauth-and-personal-access-tokens

Chronophylos avatar Jun 03 '22 12:06 Chronophylos

Thank you for your issue! Octocrab should provide an error in this case. If someone would like to fix this, I would recommend handling this in the HTTP methods (.get, .post, etc).

XAMPPRocky avatar Jun 03 '22 12:06 XAMPPRocky

@XAMPPRocky Is this issue closed?

manchicken avatar Nov 10 '22 03:11 manchicken