glx: fix security and memory issues if calloc is failed
Duplicate description PR: https://github.com/X11Libre/xserver/pull/79
You should remove changes that are just reformating like if (pointer == NULL) to to if (!pointer) one can argue wich one is more easy to read than the other but they don't fix something.
You should remove changes that are just reformating like
if (pointer == NULL)toto if (!pointer)one can argue wich one is more easy to read than the other but they don't fix something.
do u suggest splitting PR and making separate one for refactoring code? Yes, I included it in one PR, I think it's wrong.
Personally I prefer !pointer but the fact is that the majority of the X server uses == NULL, which to me indicates that this choice and these changes should be made in a more orderly way. Also I would suggest using pointer == NULL instead of !pointer in your PRs for now, for consistency with other existing null checking code.
needs rebase
needs rebase.
@GermanAizek ping
@GermanAizek needs rebase
@GermanAizek
Could you split this change into multiple commits?