xserver icon indicating copy to clipboard operation
xserver copied to clipboard

glx: fix security and memory issues if calloc is failed

Open GermanAizek opened this issue 8 months ago • 8 comments

Duplicate description PR: https://github.com/X11Libre/xserver/pull/79

GermanAizek avatar Jun 12 '25 01:06 GermanAizek

You should remove changes that are just reformating like if (pointer == NULL) to to if (!pointer) one can argue wich one is more easy to read than the other but they don't fix something.

Skarsnik avatar Jun 12 '25 11:06 Skarsnik

You should remove changes that are just reformating like if (pointer == NULL) to to if (!pointer) one can argue wich one is more easy to read than the other but they don't fix something.

do u suggest splitting PR and making separate one for refactoring code? Yes, I included it in one PR, I think it's wrong.

GermanAizek avatar Jun 12 '25 11:06 GermanAizek

Personally I prefer !pointer but the fact is that the majority of the X server uses == NULL, which to me indicates that this choice and these changes should be made in a more orderly way. Also I would suggest using pointer == NULL instead of !pointer in your PRs for now, for consistency with other existing null checking code.

xorgy avatar Jun 12 '25 12:06 xorgy

needs rebase

metux avatar Jun 12 '25 19:06 metux

needs rebase.

metux avatar Jul 23 '25 12:07 metux

@GermanAizek ping

metux avatar Jul 30 '25 09:07 metux

@GermanAizek needs rebase

metux avatar Nov 26 '25 16:11 metux

@GermanAizek

Could you split this change into multiple commits?

stefan11111 avatar Nov 26 '25 17:11 stefan11111