X11Libre
Cleaning up Clang --warnlevel=1 warnings (reported in #23)
#1406
Some of the warnings that were brought up in #23 had already been resolved, but these were the residual warnings I had encountered and fixed when compiling with Clang 19.
Rebased from master. First time contributor so I'm not really sure exactly how y'all want this, hopefully this is fine.
#1406
Some of the warnings that were brought up in #23 had already been resolved, but these were the residual warnings I had encountered and fixed when compiling with Clang 19.
Rebased from
master. First time contributor so I'm not really sure exactly how y'all want this, hopefully this is fine.
There's no need to create new PRs after rebase - you can use forced push (git push
#1406
Some of the warnings that were brought up in #23 had already been resolved, but these were the residual warnings I had encountered and fixed when compiling with Clang 19.
Rebased from
master. First time contributor so I'm not really sure exactly how y'all want this, hopefully this is fine.There's no need to create new PRs after rebase - you can use forced push (git push +)
Closing the old PR was not intentional; I renamed the branch without realizing that it would close the pull request.
#1406
Some of the warnings that were brought up in #23 had already been resolved, but these were the residual warnings I had encountered and fixed when compiling with Clang 19.
Rebased from
master. First time contributor so I'm not really sure exactly how y'all want this, hopefully this is fine.There's no need to create new PRs after rebase - you can use forced push (git push +)
Closing the old PR was not intentional; I renamed the branch without realizing that it would close the pull request.
By "renaming" you mean pushing as a new one and deleting the old one ? Yes that closes PRs.
#1406
Some of the warnings that were brought up in #23 had already been resolved, but these were the residual warnings I had encountered and fixed when compiling with Clang 19.
Rebased from
master. First time contributor so I'm not really sure exactly how y'all want this, hopefully this is fine.There's no need to create new PRs after rebase - you can use forced push (git push +)
Closing the old PR was not intentional; I renamed the branch without realizing that it would close the pull request.
By "renaming" you mean pushing as a new one and deleting the old one ? Yes that closes PRs.
Yeah. It was accidental. Everything should be good now
Do we still need this? I see that changes have already been pushed to master addressing these issues.