git-directory-deploy icon indicating copy to clipboard operation
git-directory-deploy copied to clipboard

Add positional args for directory, branch, and repository.

Open matro opened this issue 9 years ago • 4 comments

This implements [<options>] [<directory> [<branch> [<repository]]] but requires all <options> come before the positional args.

Fixes part of X1011/git-directory-deploy#14.

matro avatar Dec 11 '15 19:12 matro

This feel a little hacky to me, but it seems to work in my testing.

matro avatar Dec 11 '15 19:12 matro

as with #19, i'm going to wait until we have tests for order of preference to merge this, cause i think the env variables will override these arguments as it is currently implemented.

X1011 avatar Dec 14 '15 07:12 X1011

Got some tests committed here, though I'm still working on the positional args themselves.

matro avatar Dec 16 '15 01:12 matro

I've merged master into this, and added a couple more commits. I think this is working now. All tests pass (including one specifically for the positional args), and there're docs for this.

matro avatar Dec 18 '15 00:12 matro