open-digger icon indicating copy to clipboard operation
open-digger copied to clipboard

[Metrics] Change Request Acceptance Ratio

Open xiaoya-yaya opened this issue 3 years ago • 1 comments

Description Each change request can be in one of three states: open, merged (accepted), and closed without merge (declined). This metric measures the ratio of change requests merged (accepted) vs change requests closed without being merged.

Instance of Implementation image

Resource CHAOSS: Evolution -> Code Development Activity

xiaoya-yaya avatar Jun 02 '21 04:06 xiaoya-yaya

This issue has not been replied for 24 hours, please pay attention to this issue: @sunshinemingo @wengzhenjie

open-digger-bot[bot] avatar Jun 04 '21 01:06 open-digger-bot[bot]

Hi, i'm trying to implement this mertic. I calculate the ratio in two ways,the first is ratio = pr closed without being merged/pr merged, the second is ratio = pr merged/pr closed(including pr closed without being merged and pr merged)。The result is shown below image image

But i think the result not represented the ratio of change requests merged (accepted) vs change requests closed without being merged well. Maybe I should use a histogram,just like the Instance of Implementation?Can anyone give me some advice? @xgdyp

longyanz avatar Nov 03 '22 03:11 longyanz

I agree that the histogram is a better presentation here.

As for the value itself, I think the second way (merged/all closed) represents the meaning of this metric as "the ratio of accepted PRs among all the PRs"

xiaoya-yaya avatar Nov 03 '22 08:11 xiaoya-yaya

closed by #1097

frank-zsy avatar Dec 31 '22 12:12 frank-zsy