XPlane2Blender icon indicating copy to clipboard operation
XPlane2Blender copied to clipboard

Deprecate VLIGHT from XPlaneLights

Open tngreene opened this issue 6 years ago • 2 comments

We should mark XPLaneLights (VLIGHT) as deprecate for 3.5 in the UI. We should also make a deprecation warning.

tngreene avatar Aug 12 '18 18:08 tngreene

Btw, I think there is a pretty major bug with Default lights and the VLIGHT table -

            co = light.blenderObject.location

            self.lines.append("VLIGHT\t%s\t%s\t%s\t%s\t%s\t%s" % (
                floatToStr(co[0]), floatToStr(co[2]), floatToStr(-co[1]),
                floatToStr(light.color[0]), floatToStr(light.color[1]), floatToStr(light.color[2])
            ))

VLIGHT table is using location straight, no bake matrix. I can't imagine anyone could be using this very well.

tngreene avatar Mar 04 '20 18:03 tngreene

Not only is the location used straight, it is also relying on some bizarre global state problems that make this take the location from keyframe 1. Unit tests where an OLD_LIGHT_TYPE is animated break when trying to fix #569

tngreene avatar Jun 05 '20 14:06 tngreene