gddocs icon indicating copy to clipboard operation
gddocs copied to clipboard

Fix inconsistency and misinformation in gddocs

Open notanerd314 opened this issue 1 year ago • 3 comments

The download link for the music library song is supposed to be .ogg not .mp3. I've changed it to avoid any other confusion. I've also add some minor details in resources/levels.md and added NCS guantlets. And fixed getGJLevelLists.php mistaken as levels.

notanerd314 avatar Oct 16 '24 15:10 notanerd314

Btw, to make the ncs gauntelts "appear" from the server response you need to include the BINARY_VERSION, I haven't checked if you need the 2.206's binary version or if it just accepts anything

NCS gauntlets:

BINARY_VERSION = 46
def get_raw_gauntlets(self, get21gauntlet=False) -> str:
    '''
    Return a list of raw Gauntlets
    '''
    data = {
"secret": COMMON_SECRET,
"special": 1,
"binaryVersion": BINARY_VERSION # Used for the NCS Gautlets (for some reasons)
}
    if get21gauntlet:
        data["special"] = 0
    
    req = requests.post(ROOTURL + "database/getGJGauntlets21.php", data=data, headers=HEADERS)
    return req.text

without the NCS gauntlets:

BINARY_VERSION = 46
def get_raw_gauntlets(self, get21gauntlet=False) -> str:
    '''
    Return a list of raw Gauntlets
    '''
    data = {
"secret": COMMON_SECRET,
"special": 1
}
    if get21gauntlet:
        data["special"] = 0
    
    req = requests.post(ROOTURL + "database/getGJGauntlets21.php", data=data, headers=HEADERS)
    return req.text

Geming400 avatar Oct 26 '24 20:10 Geming400

Most of the changes look good, but please make separate PRs, one giant PR is difficult to review. Make one PR where you fix periods, other where you edit other general info etc. basically don't mix all the changes in a giant pr. Also revise which stuff has already been added (merge conflicts)

iAndyHD3 avatar Dec 30 '24 14:12 iAndyHD3

Most of the changes look good, but please make separate PRs, one giant PR is difficult to review. Make one PR where you fix periods, other where you edit other general info etc. basically don't mix all the changes in a giant pr. Also revise which stuff has already been added (merge conflicts)

Thanks

notanerd314 avatar Jan 03 '25 04:01 notanerd314