Guillaume de Jabrun

Results 22 comments of Guillaume de Jabrun

Just my 2 cents... I personnaly prefer the structure of this example project instead of the ngrx one. It's (mostly?) following official angular styleguide, in particular the folder-by-feature (https://angular.io/guide/styleguide#folders-by-feature-structure). Whereas...

I see. The Application component does have a `connectToStores`. So it means that every component added will behave like that (3 call to `connectToStores`) unless I define `shouldComponentUpdate`. Is `shouldComponentUpdate`...

Okay about `shouldComponentUpdate` :) But about `connectToStores` being called only once, something is not right then. In my example, I used `debug('ConnectToStore called');` to see when my `connectToStores` is called,...

Actually, my `connectToStores` is called 4 times. I start an action in the route config (simplified a bit here) : ``` article: { path: '/:slug', method: 'get', handler: require('../pages/Article'), action:...

(Comment edited) Actually the first one is expected too, because it's the initialState and can be useful sometimes. The "extra" calls are 3 and 4.

> In theory, the state could be based on props which would require that we run this hook, but it could be optimized to not call connectToStores if the state...

Oh my... Sorry I'm tired, I should think more before writing anything.. I'm actually using that exact `props` param in my first post..... (I was getting the id directly from...

Tested, it's not working (with android client, the web ui works of course). Done it with nginx, and it's sending back 401.

https://github.com/Wykks/ngx-mapbox-gl :smile:

Hello, There's way too much change in this PR, I'll close it. Thanks for taking the time, I'll try to continue the work