VistaPanel-Themes icon indicating copy to clipboard operation
VistaPanel-Themes copied to clipboard

dark-discord and tickets

Open Stage4000 opened this issue 2 years ago • 8 comments

Hey there just wanted you to know that viewing an open ticket with the discord dark theme is broken. The colors make it so its near impossible to read any of the contents of the page, for some reason table cells are white (or near white) with white text.

Stage4000 avatar Feb 07 '23 05:02 Stage4000

I fixed this locally with some CSS jank.

Stage4000 avatar Feb 07 '23 06:02 Stage4000

So after looking into this further, this might not be limited to the discord dark theme. It appears that the table that contains the support ticket has it's CSS set inline. I set all tables and all children of tables to have an important background color and this appears to be doing the trick.

Stage4000 avatar Feb 07 '23 15:02 Stage4000

Nice! Would you be able to open a PR and contribute the fix upstream?

4yx avatar Feb 07 '23 15:02 4yx

My changes aren't really... PR-able... I just added some raw CSS to my advert area to override the white background in the tickets table. I have not had a chance to thoroughly test that this fix doesn't cause cancer elsewhere since it is kind of broad CSS, but here it is.

<style>
.table>thead>tr>th, .table>tbody>tr>th, .table>tfoot>tr>th, .table>thead>tr>td, .table>tbody>tr>td, .table>tfoot>tr>td {
    padding:8px;
        background-color: #2c2f33 !important;
}
td{background-color: #2c2f33 !important;}
.table{background-color: #2c2f33 !important;}
</style>

Stage4000 avatar Feb 07 '23 15:02 Stage4000

I don't actually think the middle clause is needed, you may want to test further. I think that the classes 1&3 are relevant though.

Stage4000 avatar Feb 07 '23 15:02 Stage4000

I think adding background-color: #2c2f33 !important; as an insertion on line 485 of style.css might do the trick.

Stage4000 avatar Feb 07 '23 16:02 Stage4000

I'll test myself and apply a patch shortly; thank you for reporting this and highlighting where it can be applied!

4yx avatar Feb 07 '23 16:02 4yx

No lie, just spent an hour setting up an exact copy of your CDN and then testing edits.

Stage4000 avatar Feb 07 '23 20:02 Stage4000