Wurst7 icon indicating copy to clipboard operation
Wurst7 copied to clipboard

Add SafeWalk Min Depth Option Support

Open LilyKensa opened this issue 11 months ago • 2 comments

Min Depth Option For Safe Walk Hack

In this pull request, I've added a Min depth option for the hack SafeWalk, making this hack better because you will no longer be sneaking on a stair, really annoying.

[!NOTE] I only made for Minecraft 1.20.1, most of the modpack is on this version I think.

[!WARNING] I know nearly nothing about those anti-cheat mods/plugins and haven't tested any of them, so use at your own risk. As far as I know, the modified version of SafeWalk is not suspicious at all, though

How It Works

How it originally worked:

  1. In ClientPlayerEntityMixin.java, the hack add a condition to clipAtLedge() method, so whenever the hack is enabled, the player will always keep you on the ledge.
  2. In SafeWalkHack.java, it checks if the adjusted (by Edge distance option) player bounding box is empty, if so, make the player sneak.

It's not gonna work if I only adjust the bounding box, because the player will still clip at ledge, checking the bounding box on clipAtLedge() will lead to another problem too: it would wait until the bounding box is emptied, but then it's too late, the player already leaved the ledge.

So, I must make a motion prediction, if bounding box + velocity is going straight to a ledge, then clip!

How it work, modified version:

  1. Use the custom-height bounding box
  2. If bounding box + velocity is empty, clip at ledge.
  3. sneak, same condition as the original.

I also added a option named Motion prediction, it's the modifier of how much motion should be take as reference (But I don't know why, it does not differ a lot.)

Hope this helps!


P.S. Wurst API is so great :) P.S. Why spotless check :(

LilyKensa avatar Mar 01 '24 00:03 LilyKensa

[!IMPORTANT]

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot] avatar Mar 01 '24 00:03 coderabbitai[bot]

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

  • They have been superseded by another pull request
  • They are out of scope or don't align with the project
  • They have become obsolete due to other changes
  • They have bugs or conflicts that won't be resolved

github-actions[bot] avatar Apr 30 '24 02:04 github-actions[bot]