Incompatibility with Sinytra Connector, caused by setVelocityFromFluid redirect mixin (AntiWaterPush)

[finnnnnnnnnnnnnnnnn]

Pre-reporting checklist

• [X] I have searched existing issues and didn't find any previous reports of this bug.
• [X] This bug still happens in the latest version of Wurst. I've made sure my installation is up to date.
• [X] I have tried removing all other mods and the bug still happens.

Description

When attempting to use Wurst with Sinytra/Connector, an experimental mod that allows one to use Fabric mods on Forge, one gets the error

org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector setVelocityFromFluid(Lnet/minecraft/world/entity/Entity;Lnet/minecraft/world/phys/Vec3;)V in wurst.mixins.json:EntityMixin from mod wurst failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap Wurst-Client-refmap.json

The setVelocityFromFluid function does not appear to be used anywhere in Wurst's code, and when I removed it from Wurst it builds and runs successfully, aside from a visual glitch in the starting menu.

I've reported this issue to Connector but I've been informed that they won't fix this due to not supporting hacks.

Repro steps

1. Install Wurst Client, Connector, and Forgified (I've linked the specific versions I used)
2. Launch Minecraft

Wurst Client version

7.39.1

Minecraft version

1.20.1

Crash report (if applicable)

https://gist.github.com/some16/24c186d291de597c920d7e0af7c42576

[Alexander01998]

Hey @some16, thank you for the detailed bug report. It's much appreciated!

However, the setVelocityFromFluid mixin is a necessary part of the Wurst Client that makes the AntiWaterPush hack work. It is not something that can simply be removed without losing that functionality.

It might still be possible to tweak the mixin for better compatibility with mods like Sinytra Connector, but it's not immediately clear how to do this without breaking AntiWaterPush.

For now, I've gone ahead and edited the title of this issue to better reflect the situation at hand. Please avoid using phrases like "easily fixable" in future bug reports. It can unintentionally come across as quite dismissive of the complexity involved in mod/hack development - and bugs are rarely as straightforward as they seem at first.

[finnnnnnnnnnnnnnnnn]

Sorry about that, I'll avoid doing that in the future.

[github-actions[bot]]

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

• They are duplicates of other issues
• There is not enough demand
• They are no longer relevant
• There are not enough details

[blammie]

❗