Wurst7 icon indicating copy to clipboard operation
Wurst7 copied to clipboard

HealthTags improvements

Open ThisTestUser opened this issue 2 years ago • 6 comments

-Added an option to display health up to 2 decimal places. This may be useful in some cases. -Player health colors are now based upon their actual maximum health. -Added a nametag for display healthtags for mobs. The renderTag() is based upon Minecraft's code to render nametags in renderLabelIfPresent(). I use this method to display item nametags as well as the mob owner (#608).

Note: The hasMobHealthTags() method currently has no use, but if I make a pull request for MobOwner in the future, it will help prevent the tags from colliding with each other.

ThisTestUser avatar Mar 17 '23 23:03 ThisTestUser

does it also display max health?

Cyclopropinon avatar Apr 27 '23 18:04 Cyclopropinon

For mobs, always. For players, it is selectable with a checkbox.

ThisTestUser avatar May 28 '23 15:05 ThisTestUser

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

  • They have been superseded by another pull request
  • They are out of scope or don't align with the project
  • They have become obsolete due to other changes
  • They have bugs or conflicts that won't be resolved

github-actions[bot] avatar Oct 22 '23 02:10 github-actions[bot]

Walkthrough

The recent changes involve enhancements to the HealthTagsHack class in a Minecraft client mod, improving the rendering of health information above entities. The modifications include formatting health values, adjusting rendering based on entity properties, and adding configuration settings for display precision and conditions. Additionally, support classes like RenderUtils and mixins have been updated to handle new rendering logic and settings. A new RoundingPrecisionSetting class has been introduced to manage numerical precision for health values.

Changes

File Path Change Summary
.../hacks/HealthTagsHack.java
.../util/RenderUtils.java
Enhanced rendering of health tags above mobs with new formatting and settings; updated tag rendering logic, including scale, visibility, and distance-based behavior.
.../mixin/EntityRendererMixin.java Modified method to cast text to MutableText for health addition.
.../settings/RoundingPrecisionSetting.java Introduced a new class for managing rounding precision of decimal numbers.
.../settings/SliderSetting.java Added a ROUNDING_PRECISION constant and updated value display behavior.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 22 '23 18:10 coderabbitai[bot]

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

  • They have been superseded by another pull request
  • They are out of scope or don't align with the project
  • They have become obsolete due to other changes
  • They have bugs or conflicts that won't be resolved

github-actions[bot] avatar Dec 22 '23 02:12 github-actions[bot]

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

  • They have been superseded by another pull request
  • They are out of scope or don't align with the project
  • They have become obsolete due to other changes
  • They have bugs or conflicts that won't be resolved

github-actions[bot] avatar Mar 04 '24 02:03 github-actions[bot]