Fixed Skin Preview

[Hi-ImKyle]

Fixed Skin Preview

• Fixed Skin Preview on Alt Manager Screen
• Skin Preview when adding an alt or editing an alt will not show if it's a Mojang Account
• Moved New SkinAPI Related Methods to SkinUtils
• Added AutoSwing Hack to swing if it's possible to hit an entity
• Redid CLA thingy for the pull request

Description

What have you added and what does it do? (Alternatively, what have you fixed and how does it work?) Reimplemented the PlayerSkinTexture into PlayerSkinFetcher to accommodate for the skin API changes Mojang did a while back. This new skin fetcher uses the original methods the skin stealer used which are now located in SkinUtils

(Optional) screenshots / videos

#154 for screenshots

[CLAassistant]

All committers have signed the CLA.

[HeyBanditoz]

[00:05:15] [main/INFO] (Minecraft) [STDERR]: java.lang.NullPointerException
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.wurstclient.altmanager.PlayerSkinFetcher.<init>(PlayerSkinFetcher.java:52)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.wurstclient.altmanager.PlayerSkinFetcher.Fetch(PlayerSkinFetcher.java:42)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.wurstclient.altmanager.AltRenderer.bindSkinTexture(AltRenderer.java:44)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.wurstclient.altmanager.AltRenderer.drawAltFace(AltRenderer.java:62)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.wurstclient.altmanager.screens.AltManagerScreen$ListGui.renderItem(AltManagerScreen.java:409)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.wurstclient.util.ListWidget.renderList(ListWidget.java:402)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.wurstclient.util.ListWidget.render(ListWidget.java:157)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.wurstclient.altmanager.screens.AltManagerScreen.render(AltManagerScreen.java:269)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.minecraft.client.render.GameRenderer.render(GameRenderer.java:603)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1021)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.minecraft.client.MinecraftClient.run(MinecraftClient.java:654)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.minecraft.client.main.Main.main(Main.java:215)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:192)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:140)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)
[00:05:15] [main/INFO] (Minecraft) [STDERR]: 	at net.fabricmc.devlaunchinjector.Main.main(Main.java:86)

[Hi-ImKyle]

Well, as far as I'm concerned you're trying to get a skin for a user that doesn't exist. Email addresses won't work as you can't look up a user by email. And in all honesty, this was by no means a definitive fix, but a proof of concept that it can work again. Out of curiosity, when you tried the build and you got the NullPointerException, what username were you searching for?

[Hi-ImKyle]

@HeyBanditoz, if you can please try to recreate the NullPointerException with the current updates I just pushed to the branch.

[HeyBanditoz]

@HeyBanditoz, if you can please try to recreate the NullPointerException with the current updates I just pushed to the branch.

NPE was fixed but it takes a very long time to open the screen with a large list of emails.

[Hi-ImKyle]

NPE was fixed but it takes a very long time to open the screen with a large list of emails.

I can try and sort that. Never worked with Async stuff on Java before so it may be jank, give me a little while.

EDIT: This may be something @Alexander01998 can fix though?

[github-actions[bot]]

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

• They have been superseded by another pull request
• They are out of scope or don't align with the project
• They have become obsolete due to other changes
• They have bugs or conflicts that won't be resolved