harbour-fernschreiber icon indicating copy to clipboard operation
harbour-fernschreiber copied to clipboard

Published 20 hours ago • verified publisher icon Wunderfitz

Landscape layout issues

Open monich opened this issue 1 year ago • 6 comments

PR #540 introduced a couple of landscape layout issues.

  1. Preview text doesn't use the full width of the bubble: image

  2. In "own" bubbles everything is aligned to the right, except for the media (image/video/sticker) item: image

monich avatar Dec 04 '23 00:12 monich

Yep, now as you say it, I notice that, too.

Wunderfitz avatar Dec 04 '23 06:12 Wunderfitz

I don't see it as a bug.

  1. Preview item is usually limited and short.
  2. In the near future we might want to display many attachments (as desktop app does). So they will be shown side by side.

However, aligning the items to the right may look good.

mbarashkov avatar Dec 04 '23 07:12 mbarashkov

This is how my thinking goes.

The preview title takes two lines while it could fit into one if it were wider. That wastes valuable vertical space in the landscape mode.

To save even more space the secondary preview text could be limited (in collapsed state) to 2 lines in the landscape mode vs 3 lines in portrait.

When there will be multiple media items inside the same bubble, the layout will most likely have to change. But that's a separate thing and we are not there yet.

monich avatar Dec 04 '23 09:12 monich

Expanding the preview to fill message width will make it tall. (not the text, but the image).

mbarashkov avatar Dec 04 '23 09:12 mbarashkov

I understand why the image was narrowed, I meant expanding the preview title (which could be limited to a single line at landscape vs 2 lines in portrait) and the secondary text.

monich avatar Dec 04 '23 10:12 monich

Addressed in updated https://github.com/Wunderfitz/harbour-fernschreiber/pull/548 @monich

mbarashkov avatar Dec 22 '23 13:12 mbarashkov