wgpu-profiler icon indicating copy to clipboard operation
wgpu-profiler copied to clipboard

Update to wgpu 0.20

Open waywardmonkeys opened this issue 1 year ago • 9 comments

waywardmonkeys avatar Apr 29 '24 00:04 waywardmonkeys

I think this might also need to deal with the new timestamp related features flag?

DJMcNab avatar Apr 29 '24 06:04 DJMcNab

Unfortunately, I need to leave now unexpectedly to drive 250km and won't be back for some hours, so I won't be able to get back to this until about 24 hours from now at the earliest, so if anyone else can pick it up and run with it, they're welcome to it!

waywardmonkeys avatar Apr 29 '24 08:04 waywardmonkeys

I pushed an update but forgot to mention it ... this at least passes tests but there may be a better way to do parts of it?

waywardmonkeys avatar May 01 '24 02:05 waywardmonkeys

@Wumpf Just checking in on this if you have the time. We'd like to update Vello to wgpu 0.20 for the shader compilation improvements and this is needed for that.

waywardmonkeys avatar May 02 '24 14:05 waywardmonkeys

(But I know everyone is busy with the run up to RustNL and other things!)

waywardmonkeys avatar May 02 '24 14:05 waywardmonkeys

I'll try to have a close look and release a new version until Monday but don't want to promise anything ;-) unfortunately not RustNL busy, just regular busy

Wumpf avatar May 02 '24 21:05 Wumpf

I'm on it, but looks like I stumbled over a bug; managed to violate an internal invariant 🤔

Edit: Figured it out: Has to do with the fact that you can how have encoder scopes without queries containing timestamp_write scopes with queries containing pass scopes without queries. Before this wasn't possible.

Wumpf avatar May 04 '24 09:05 Wumpf

I am on a trip this weekend without my laptop. (First time without a computer in over a decade!)

I will try to visually review it via phone tonight.

thanks for doing all of this!

waywardmonkeys avatar May 04 '24 10:05 waywardmonkeys

@Wumpf This seems to work once I fix up the code in the vello example that uses it. (It displays some stuff on screen visually.)

waywardmonkeys avatar May 06 '24 14:05 waywardmonkeys