dsync icon indicating copy to clipboard operation
dsync copied to clipboard

Consider using `diesel_table_macro_syntax` for parsing `schema.rs` files

Open weiznich opened this issue 1 year ago • 3 comments

Diesel internally uses the diesel_table_macro_syntax crate to parse the schema.rs file. It might be a good idea to just use the same code in dsync to make sure that it supports all of the macro syntax without keeping close track of all variants that are supported by diesel.

weiznich avatar Nov 05 '24 13:11 weiznich

This sounds like a very good idea. Though I have not written any of the current parsing code - maybe there was a reason why existing Diesel macros were not used. @Wulf @hasezoey any thoughts / insights you can share on this?

longsleep avatar Nov 07 '24 12:11 longsleep

any thoughts / insights you can share on this?

at least from my side, i didnt know such a crate existed and just refactored the existing parsing code since coming to this project.

hasezoey avatar Nov 07 '24 12:11 hasezoey

Georg, thanks for bringing this to our attention. I wasn't aware you had split it so nicely :)

Wulf avatar Nov 22 '24 01:11 Wulf