create-rust-app icon indicating copy to clipboard operation
create-rust-app copied to clipboard
verified publisher icon Wulf

general cleanup and maintenance

Open AnthonyMichaelTDM opened this issue 2 years ago • 2 comments

  • changed StatusCode from i31 to u16.
  • refactored logic
  • expanded documentation
  • added TODOs
  • made some functions more generic (to improve API w/o causing breaking changes)

this is just a start, there's a lot of TODOs I still need to tackle as well

AnthonyMichaelTDM avatar Nov 12 '23 09:11 AnthonyMichaelTDM

Whao! Thanks for taking the time to do this.

Let's do this MR as usual, but going forward, it'll be much easier for me if we have smaller-sized changes! I know it's hard sometimes, especially when we combine everything from a working session into a single MR, but it makes it easier for me as I don't have all the time in the world (that way we can maintain shipping velocity!). I hope you understand :)

🤗

Wulf avatar Nov 18 '23 20:11 Wulf

sure, I can have this as base then do subsequent PR's to address the TOOD's and whatnot

AnthonyMichaelTDM avatar Nov 19 '23 00:11 AnthonyMichaelTDM

I forgot why I hadn't merged this yet, it's been a while... I plan on looking over it again soon though

AnthonyMichaelTDM avatar Mar 30 '24 09:03 AnthonyMichaelTDM

Okay I think it's good now, gonna do one final review before I merge though

AnthonyMichaelTDM avatar May 02 '24 22:05 AnthonyMichaelTDM