compile-hero icon indicating copy to clipboard operation
compile-hero copied to clipboard

Will not compile .pug to HTML unless "Generate-minified-HTML" setting is enabled

Open jasper-zanjani opened this issue 3 years ago β€’ 4 comments

Compile Hero will not compile .pug files to HTML unless the generate-minified-html option is enabled. Unchecking this feature should still allow Compile Hero to compile to normal HTML.

Steps to reproduce

  "compile-hero.disable-compile-files-on-did-save-code": false,
  "compile-hero.generate-minified-html": true,

Saving test.pug or manually clicking "Compile files" from the context menu on the File Explorer compiles test.pug to two HTML files in the specified output directory:

dist/
β”œβ”€β”€ test.html
└── test.min.html

0 directories, 2 files

Changing generate-minified-html to false prevents Compile Hero from compiling the pug file at all. The specified output directory is not populated or generated. Removing the setting from the settings.json entirely also results in no HTML output.

This behavior is consistent across Windows, OS X, and Linux environments.

jasper-zanjani avatar Sep 21 '20 17:09 jasper-zanjani

Compile Hero will not compile .pug files to HTML unless the generate-minified-html option is enabled. Unchecking this feature should still allow Compile Hero to compile to normal HTML.

Steps to reproduce

  "compile-hero.disable-compile-files-on-did-save-code": false,
  "compile-hero.generate-minified-html": true,

Saving test.pug or manually clicking "Compile files" from the context menu on the File Explorer compiles test.pug to two HTML files in the specified output directory:

dist/
β”œβ”€β”€ test.html
└── test.min.html

0 directories, 2 files

Changing generate-minified-html to false prevents Compile Hero from compiling the pug file at all. The specified output directory is not populated or generated. Removing the setting from the settings.json entirely also results in no HTML output.

This behavior is consistent across Windows, OS X, and Linux environments.

I changed the settings according to your description, but the html is still normal output, can you record a video and let me see. like this: https://imgur.com/bddGTW0

Wscats avatar Sep 22 '20 03:09 Wscats

I installed Compile Hero, tried to save a .pug file and the same thing happened. It wouldn't save, even though it said "Compilation Successed!" (succeeded, btw). I googled, came upon this thread, enabled minified html and it compiled successfully.

Bestulo avatar Oct 03 '20 17:10 Bestulo

that's true, I wasn't sure if "successed" was some sort of joke but if it's not meant to be cute it should be fixed

jasper-zanjani avatar Oct 03 '20 21:10 jasper-zanjani

successed

Now the successful reminder is not very friendly, because some code syntax is actually a warning rather than an error, but it will also remind failed when it warns, and subsequent versions will consider optimization.

Wscats avatar Oct 07 '20 03:10 Wscats