adaptfilt icon indicating copy to clipboard operation
adaptfilt copied to clipboard

Issue while trying to compile with latest python

Open kalpana-manickavasagam opened this issue 4 years ago • 2 comments
trafficstars

File "/usr/local/lib/python3.6/dist-packages/adaptfilt/init.py", line 41 print ' LMS: ', lmsres ^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print(' LMS: ', lmsres)?

kalpana-manickavasagam avatar Dec 15 '20 00:12 kalpana-manickavasagam

Yes, this module was written for Python 2 and has not been updated for a while. There is a PR (#3) that fixes this particular detail, but I suspect a few more minor changes are needed to support Python 3.

We will gladly accept a PR, though, so don't hold back :)

tausen avatar Jan 05 '21 07:01 tausen

Hi @tausen! Congrats for this library! Would you have a Python3 version? Thanks a lot in advance :)

josephernest avatar Jul 11 '24 07:07 josephernest

Hi @josephernest! Happy to see there's still some interest in this library, despite it being unmaintained for a decade :) I've (finally) merged an old v0.3 PR which added Python 3 support (among a few other things) and uploaded it to pypi, so it should work now.

tausen avatar Jul 14 '24 15:07 tausen