Wraith

Just for clarity, what is this waiting on? and if it's me can you tell me what is needed?

``` D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule\ActivityHelper.cs(68,26): warning SA1010: Opening square brackets should not be preceded by a space [D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule\OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.csproj] ``` This is unavoidable due to conflicting rules. One rule requires a space and another...

> > 'm also curious about whether constants for the keys would be better. > > Using one of the existing constants would require that I add a project reference...

That's a pretty aggressive stale marking behaviour. Is there a specific thing blocking this PR?

> The new StyleCop version seems to do the right thing and stops warning. I've rebased which should pick up the new stylecop.

I've added a changelog entry. I looked at how to add tests and couldn't find a good way to do it. The Opentelemetry.Trace namespace isn't available in the HttpInListener test...

Disappointing.

I have no problem with redaction existing in the current form and being enabled by default, but I do want to be able to deal with it in a natural...

This is a problem which affects running tests in SqlClient and has done for many years. If there is a chance it can be fixed that would be very useful...