WowUp icon indicating copy to clipboard operation
WowUp copied to clipboard

Add WowHead as an upstream Provider

Open yoshimo opened this issue 5 years ago • 4 comments

Is your feature request related to a problem? Please describe. WoWhead.com is a useful database that people rely on to help with various projects or when they are stuck. That requires people to supply collected data with the wowhead looter addon

Describe the solution you'd like WowUp should detect the wowhead looter addon and update it Bonus Points if we have a module to upload collected data

Describe alternatives you've considered The alternative is always running the official client.

Notes The wowhead updater checks client.wowhead.com/files/updates.dat which includes addon files and their MD5 hash to compare against the local files for each game version, beta/ptr/classic/classic_ptr/retail.

A mismatch will cause a download for each file specified in the updates.dat like this: client.wowhead.com/files/beta/Wowhead_Looter.lua

yoshimo avatar Nov 15 '20 17:11 yoshimo

The Client uses GZ to pack the WDB and SavedVariables files from each wow folder and posts them to http://client.wowhead.com/upload.php?username=USER&password=NUMBERS&clientversion=1.9.43&looterversion=90001&os=windows&osversion=6.2.0.0.256&realmlist=&portal=EU%0AEU%0Atest%0Atest%0AEU%0AEU&locale=deDE locale, region, os and versions of course can differ between uploads and different people.

The +Wowhead_Looter.lua in the WTF\Account\NUMBER\SavedVariables folder has a line wlUploaded = 0 , which will switch to 3 once the client has done the upload.

The request fills the upload form with User-Agent: WowheadClient/1.9.43 Content-Type: multipart/form-data; boundary=---------------------------316113421 Content-Length: 4483

and then we have numbered file entries for various kinds of data Content-Disposition: form-data; name="file0"; filename="BETA_9.0.2.36671_ACCOUNT_SavedVariables.lua.gz" Content-Disposition: form-data; name="file1"; filename="BETA_9.0.2.36671_deDE_DBCache.bin.gz" Content-Disposition: form-data; name="file2"; filename="CLASSIC_1.13.5.36325_deDE_DBCache.bin.gz" Content-Disposition: form-data; name="file3"; filename="LIVE_9.0.2.36665_deDE_DBCache.bin.gz" Content-Disposition: form-data; name="file4"; filename="PTR_9.0.2.36639_deDE_DBCache.bin.gz"

WH nginx acknowledges this by replying with uploadResult 0 uploadCount 5

yoshimo avatar Nov 19 '20 08:11 yoshimo

Is there any reason you'd ever want to run the wowhead addon without the app? To me it feels like the they are a package deal, and makes no sense to have one and not the other. I don't think this particular functionality belongs in wowup to be honest. It would cost time to reverse engineer and maintain this and we'd constantly have to tweak it if wowhead changes something in their backend or addon.

linaori avatar Nov 19 '20 08:11 linaori

One stop shop solution. People are lazy including developers therefore the likelihood of this procedure breaking often and soon is in my eyes rather low. It has worked in the past, why change it?

yoshimo avatar Nov 19 '20 08:11 yoshimo

Because we'd basically be duplicating functionality that we have to maintain, and isn't really the job of an addon manager. If this feature would be added to WowUp, I think it's best to at least ask wowhead if they are okay with that and how we should proceed. The final call is up to @jliddev

linaori avatar Nov 19 '20 08:11 linaori