WorldWindJava
WorldWindJava copied to clipboard
WorldWindEarth
Added Symbols: Block 2.X.1.1 and Penetrate 2.X.1.17
Description of the Change
Created a new-pull request from the changes in upstream pull-request #134. New symbols namely Block 2.X.1.1 and Penetrate 2.X.1.17 were added by @mziolkowski.
Why Should This Be In Core?
The Tactical Graphic database should be larger.
Benefits
Another useful symbol in the code.
Potential Drawbacks
None
Applicable Issues
None
Note: this is not ready to merge yet. I picked up a bug when running the TacticalGraphics example. When the positions of the penetrate symbol is swapped with the block symbol so that the penetrate symbol's orientation is rotated 180-degrees the arrows are incorrectly drawn. We need to fix this before we can merge. We should also probably add setter methods to control the arrow's angle and lengths. This is present if you look at the AttackByFirePosition class.
Hi @wcmatthysen,
Any news about this PR status?
Hi @ComBatVision, you can have a look at the code and fix it up if you need it in your project. I'm not working on WorldWind at this point in time anymore.
@ComBatVision: please merge this. You might want to give me merge privileges. Thanks.
I have merged it. I will give you privileges later. Now I am little bit busy.
вт, 27 груд. 2022, 19:25 користувач Glenn Burkhardt < @.***> пише:
@ComBatVision https://github.com/ComBatVision: please merge this. You might want to give me merge privileges. Thanks.
— Reply to this email directly, view it on GitHub https://github.com/WorldWindEarth/WorldWindJava/pull/65#issuecomment-1366061369, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7IVCXJWWLGU6FI2FEQJFLWPMRALANCNFSM4IGEFVDA . You are receiving this because you were mentioned.Message ID: @.***>